[DolphinWX] Added warning to Wii disc compression #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FileName.append(".iso"); | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Helios747
force-pushed
the
WiiDiscWarning
branch
from
d5ec18c
to
dcae85d
Compare
| @@ -1292,3 +1298,14 @@ void CGameListCtrl::UnselectAll() | |||
| SetItemState(i, 0, wxLIST_STATE_SELECTED); | |||
| } | |||
| } | |||
| bool CGameListCtrl::WiiCompressWarning(const GameListItem* iso) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Helios747
force-pushed
the
WiiDiscWarning
branch
from
dcae85d
to
7f43fdf
Compare
| @@ -107,4 +107,5 @@ class CGameListCtrl : public wxListCtrl | |||
| static size_t m_numberItem; | |||
| static bool CompressCB(const std::string& text, float percent, void* arg); | |||
| static bool MultiCompressCB(const std::string& text, float percent, void* arg); | |||
| bool WiiCompressWarning(const GameListItem* iso); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Helios747
force-pushed
the
WiiDiscWarning
branch
from
7f43fdf
to
1d05153
Compare
|
Phrasing sounds off to me. I'd suggest something closer to: "Compressing a Wii disc image will irreversibly change the compressed copy by removing padding data." |
Helios747
force-pushed
the
WiiDiscWarning
branch
2 times, most recently
from
c001b82
to
7327165
Compare
| @@ -107,4 +107,5 @@ class CGameListCtrl : public wxListCtrl | |||
| static size_t m_numberItem; | |||
| static bool CompressCB(const std::string& text, float percent, void* arg); | |||
| static bool MultiCompressCB(const std::string& text, float percent, void* arg); | |||
| static bool WiiCompressWarning(const GameListItem* iso); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
Helios747
force-pushed
the
WiiDiscWarning
branch
from
7327165
to
013d552
Compare
|
Looks good to me! |
delroth
added a commit
that referenced
this pull request
Nov 1, 2015
[DolphinWX] Added warning to Wii disc compression
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have no idea that compressing Wii images screws with their file. Now they do.