XFMem: Don't warn on writes of zero to unknown registers. #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,7 +184,8 @@ static void XFRegWritten(int transferSize, u32 baseAddress, DataReader src) | |||
| case 0x1017: | |||
|
|
|||
| default: | |||
| WARN_LOG(VIDEO, "Unknown XF Reg: %x=%x", address, newValue); | |||
| if(newValue != 0) // Ignore writes of zero. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Well, someone has commented out an assert(0) for both of those, implying that the code hasn't been verified at all. |
phire
added a commit
that referenced
this pull request
Nov 9, 2015
XFMem: Don't warn on writes of zero to unknown registers.
Pokechu22
added a commit
to Pokechu22/dolphin
that referenced
this pull request
Mar 28, 2021
This avoids some warnings, which were originally fixed by ignoring loads with a value of zero (see 636bedb / dolphin-emu#3242). Note that FifoCI will report some changes, but only on the first frame; these seem to be timing related as they don't happen if a different write is used to replace skipped ones.
Pokechu22
added a commit
to Pokechu22/dolphin
that referenced
this pull request
Apr 6, 2021
This avoids some warnings, which were originally fixed by ignoring loads with a value of zero (see 636bedb / dolphin-emu#3242). Note that FifoCI will report some changes, but only on the first frame; these seem to be timing related as they don't happen if a different write is used to replace skipped ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of these extra warnings in FifoCI: