Reset the GC adapter rumble when stopping a game #3244
Conversation
|
One of the issue comments mentions rumble not resetting when loading savestates. Should that also be fixed? (There might be more situations too, like pausing or using frame advance, but those aren't common) |
|
Would it be acceptable to do the reset on Core::PauseAndLock? Or would that be overkill? |
|
That sounds appropriate. The worst thing I can imagine happening is canceling a rumble command when a controller gets (dis)connected, and I think it even might be limited to (dis)connecting them using the GUI or hotkeys. |
| s_controller_rumble[1] = 0; | ||
| s_controller_rumble[2] = 0; | ||
| s_controller_rumble[3] = 0; | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mathieui
force-pushed
the
rumble-reset
branch
from
5a946eb
to
1016716
Compare
mathieui
force-pushed
the
rumble-reset
branch
from
1016716
to
6177433
Compare
|
LGTM, but needs a rebase |
|
I tried this out a bit, and the screenshot qualm really isn't a big deal. Most of the time I'm not holding the controller when taking a screenshot anyway. |
And when loading a savestate, pausing, and starting dolphin as well (right after the libusb initialization). Intended fix for issue 9001
mathieui
force-pushed
the
rumble-reset
branch
from
6177433
to
680ebfe
Compare
Reset the GC adapter rumble when stopping a game
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
And when starting dolphin as well (right after the libusb
initialization).
Intended fix for issue 9001