WII_IPC_HLE_Device_usb: const correctness for function parameters #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data passed in isn't modified in these functions Also normalizes variables with prefixed underscores in the modified functions (and normalizes outliers to our current coding style), as single-underscore followed by any lowercased/uppercased character is reserved for use in the global namespace (it's a common misconception this is assumed to only be the case for underscores followed by a capital character, but this is only the case in C, not C++).
|
Cleanup always LGTM :) |
degasus
added a commit
that referenced
this pull request
Dec 6, 2015
WII_IPC_HLE_Device_usb: const correctness for function parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data passed in isn't modified in these functions.
Also normalizes variables with prefixed underscores in the modified functions (and normalizes outliers to our current coding style), as single-underscore followed by any lowercased/uppercased character is reserved for use in the global namespace (it's a common misconception this is assumed to only be the case for underscores followed by a capital character, but this is only the case in C, not C++).