Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Namespace MemoryUtil #3386

Merged
merged 2 commits into from Aug 19, 2016
Merged

Common: Namespace MemoryUtil #3386

merged 2 commits into from Aug 19, 2016

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Dec 23, 2015 •
edited by delroth

Gets these out of the global namespace.

This change is Reviewable

@Parlane
Copy link
Member

Parlane commented Jul 14, 2016

LGTM, rebase and this will go through.

@lioncash
Common: namespace MemoryUtil
e01c143
@lioncash
MemoryUtil: Remove unimplemented/unused functions
fbc0aaf 
GuardMemoryMake/GuardMemoryUnmake are unimplemented prototypes.
GetPageSize is an unused function.
@lioncash
Copy link
Member Author

Oh right, forgot to comment that this is rebased now.

@JosJuice
Copy link
Member

Reviewed 15 of 15 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@JosJuice JosJuice merged commit 31c530c into dolphin-emu:master Aug 19, 2016
@lioncash lioncash deleted the memory branch August 19, 2016 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@lioncash @Parlane @JosJuice