CheatSearchTab: Use an enum for filter masks rather than ints #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| inline ComparisonMask operator & (ComparisonMask comp1, ComparisonMask comp2) | ||
| { | ||
| return static_cast<ComparisonMask>( static_cast<int>(comp1) & |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
rabbott99
force-pushed
the
cheat-search
branch
from
ce81541
to
383d5db
Compare
| // 6 : not equal | ||
| static const int filters[] = { 6, 1, 2, 4 }; | ||
| int filter_mask = filters[m_search_type->GetSelection()]; | ||
| static const ComparisonMask filters[] = { ComparisonMask::EQUAL | ComparisonMask::GREATER_THAN | ComparisonMask::LESS_THAN, // Unknown |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
rabbott99
force-pushed
the
cheat-search
branch
from
383d5db
to
ad54ff4
Compare
rabbott99
force-pushed
the
cheat-search
branch
from
ad54ff4
to
5d61e06
Compare
skidau
added a commit
that referenced
this pull request
Dec 29, 2015
CheatSearchTab: Use an enum for filter masks rather than ints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes issue 8974, which was the result of removing the first element of filters[] in #2813.