Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderGen: Remove virtual methods and string from ShaderGeneratorInterface. #3431

Merged
merged 1 commit into from
Jan 5, 2016
Merged

ShaderGen: Remove virtual methods and string from ShaderGeneratorInterface. #3431

merged 1 commit into from
Jan 5, 2016

Commits on Jan 2, 2016

  1. ShaderGen: Remove virtual methods from ShaderGeneratorInterface, move… 

    … string buffer to ShaderCode

This fixes the crashes occuring at startup with a non-empty shader cache.
Because LinearDiskCache reads/writes to the storage of ShaderUid, ShaderUid must be trivially copyable.
Additionally, adds a static assert to LinearDiskCache to ensure this doesn't happen in the future.

The initialization of ShaderUid data has been moved to the code generation functions, so the above condition holds true.
    @stenzek
    stenzek committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    617f9d9 View commit details
    Browse the repository at this point in the history