Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds rotation PP shaders and removes Qualcomm screen rotation workaround from DriverDetails. #347

Closed

Conversation

Sonicadvance1
Copy link
Contributor

This removes the workaround in the actual source for Qualcomm's dumb rotation that happens with glBlitFramebuffer and instead uses post processing shaders to do the rotation for us.

Adds two utility shaders for rotation.
Requires PR #346 first before merging.

These are utility shaders for Qualcomm devices
These are two shaders, one for a simple 90 rotation for fixing older driver versions that run everything rotated 90 degrees.
The other for the newer drivers that rotate by 180 degrees.
We now handle rotation issues in post processing shaders.
@Sonicadvance1 Sonicadvance1 changed the title Adds rotation PP shaders and remove Qualcomm screen rotation workaround form DriverDetails. Adds rotation PP shaders and removes Qualcomm screen rotation workaround from DriverDetails. May 5, 2014
@lioncash
Copy link
Member

lioncash commented May 5, 2014

If the shaders are only for Android, maybe a subdirectory for those shaders should be made (one named "Android" could work) just to make it obvious they're only intended for it.

@Sonicadvance1
Copy link
Contributor Author

Fun enough, I was testing this on my K1.
Turns out that since we use attributeless rendering for the PP shaders, the PP shaders don't work at all on Qualcomm/Adreno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants