Fix SCMRevGen by running system native CScript #3512
Conversation
Build Events are run in an 32 bit environment, therefore both program files environment strings resolve to the x86 program files folder on 64 Bit systems. If Git is 64 bit and installed into the x64 program files it can't be found by the script.
|
@shuffle2 WDYT? |
|
Don't think it's the correct way to fix - although I did notice git is now installed to x64 program files on VS2015 update 1. |
|
They moved from msysgit to Git-for-Windows. IMO this works fine, regardless of the git bitness. Since Dolphin is only developed on 64 Bit systems, the CScript path is always resolved to the 64 Bit Version (though on 32 Bit, it would be the 32 Bit version). In the Script itself, both Program Files and Programs Files(x86) are searched for Git, therefore it works regardless of the Git bitness. Even if someone tries to build Dolphin on a 32 bit system, this should hold, as at least one environment string is resolved to Program Files, which is only present once on 32 bit systems. |
Ah, OK. lgtm then, but i dont think this commit is really important for 5.0? This would matter for post-5.0 when we move to VS2015 Update 1 (or whatever). |
Fix SCMRevGen by running system native CScript
|
meh |
|
I think this will not work on Windows 10 - I can't |
|
I did test it on Windows 10 and it works. |
|
It however does not work when using a 64 bit msbuild to build Dolphin... :( |
|
I have tested this, it works ONLY when running from 32bit cmd.exe (ie. from SysWoW64) on my Windows 10 x64, does not work from x64 cmd.exe - |
|
@delroth why are you using 64bit msbuild, anyways? |
Build Events are run in an 32 bit environment, therefore both program files environment strings resolve to the x86 program files folder on 64 Bit systems. If Git is 64 bit and installed into the x64 program files it can't be found by the script.