Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVDInterface: Reduce a global variable to translation unit scope #3558

Merged
merged 2 commits into from
Jan 25, 2016

Conversation

lioncash
Copy link
Member

g_bStream isn't used anywhere else.

Also corrects the prefixes on other translation unit scoped variables as well.

Review on Reviewable

@JosJuice
Copy link
Member

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Source/Core/Core/HW/DVDInterface.cpp, line 236 [r1] (raw file):
s_audio_position


Comments from the review on Reviewable.io

@JosJuice
Copy link
Member

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@degasus
Copy link
Member

degasus commented Jan 24, 2016

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@BhaaLseN
Copy link
Member

LGTM apart from those two underscores (which may or may not belong in this PR; but since you changed others it probably doesn't matter much...)


Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


Source/Core/Core/HW/DVDInterface.cpp, line 509 [r2] (raw file):
You might want to rename this one too, while you're at it (underscore at start)


Source/Core/Core/HW/DVDInterface.cpp, line 627 [r2] (raw file):
And perhaps this one too.


Comments from the review on Reviewable.io

@delroth
Copy link
Member

delroth commented Jan 25, 2016

Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

1 similar comment
@delroth
Copy link
Member

delroth commented Jan 25, 2016

Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

@degasus
Copy link
Member

degasus commented Jan 25, 2016

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

1 similar comment
@JosJuice
Copy link
Member

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

lioncash added a commit that referenced this pull request Jan 25, 2016
DVDInterface: Reduce a global variable to translation unit scope
@lioncash lioncash merged commit ee0fbdf into dolphin-emu:master Jan 25, 2016
@lioncash lioncash deleted the dvd-global branch January 25, 2016 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants