-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVDInterface: Reduce a global variable to translation unit scope #3558
Conversation
Reviewed 2 of 2 files at r1. Source/Core/Core/HW/DVDInterface.cpp, line 236 [r1] (raw file): Comments from the review on Reviewable.io |
Reviewed 1 of 1 files at r2. Comments from the review on Reviewable.io |
Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
LGTM apart from those two underscores (which may or may not belong in this PR; but since you changed others it probably doesn't matter much...) Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Source/Core/Core/HW/DVDInterface.cpp, line 509 [r2] (raw file): Source/Core/Core/HW/DVDInterface.cpp, line 627 [r2] (raw file): Comments from the review on Reviewable.io |
Reviewed 1 of 2 files at r1, 1 of 1 files at r3. Comments from the review on Reviewable.io |
1 similar comment
Reviewed 1 of 2 files at r1, 1 of 1 files at r3. Comments from the review on Reviewable.io |
Reviewed 1 of 1 files at r3. Comments from the review on Reviewable.io |
1 similar comment
Reviewed 1 of 1 files at r3. Comments from the review on Reviewable.io |
DVDInterface: Reduce a global variable to translation unit scope
g_bStream isn't used anywhere else.
Also corrects the prefixes on other translation unit scoped variables as well.