Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fifoplayer: Fix dual core #3573

Merged
merged 3 commits into from
Jan 29, 2016
Merged

Conversation

degasus
Copy link
Member

@degasus degasus commented Jan 26, 2016

This commit adds fifo bound checking for the fifo player, so now, it can be used with dual core.

Review on Reviewable

@lioncash
Copy link
Member

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.


Source/Core/Core/FifoPlayer/FifoPlayer.h, line 116 [r1] (raw file):
These can be const (or static)


Comments from the review on Reviewable.io

@Sonicadvance1
Copy link
Contributor

Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

Sonicadvance1 added a commit that referenced this pull request Jan 29, 2016
@Sonicadvance1 Sonicadvance1 merged commit ea3a457 into dolphin-emu:master Jan 29, 2016
@degasus degasus deleted the fifoplayer branch February 3, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants