Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSPEmitter: Minor changes #3608

Closed
wants to merge 5 commits into from
Closed

DSPEmitter: Minor changes #3608

wants to merge 5 commits into from

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Feb 8, 2016

Basic stuff. Feel free to suggest better names for the unresolved jump functions if they can be made more informative.

Review on Reviewable

This also provides extensions to the emitter to make both the size
constant, and unresolved jump list private.
In its current state, this counts nothing, and is useless
@BhaaLseN
Copy link
Member

BhaaLseN commented Feb 8, 2016

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Source/Core/Core/DSP/DSPCore.cpp, line 325 [r1] (raw file):
This loop kinda feels like it could be written in a nicer way (like, a for-each or something like that). Not sure if that is actually possible tho, since Compile modifies the list of unresolved jumps iirc).
It also leaves the impression that it might belong in the DSP Jit class, since every call is going thru g_dsp_jit.


Source/Core/Core/DSP/DSPEmitter.cpp, line 426 [r1] (raw file):
Has(Any)UnresolvedJumpsAtAddress perhaps?


Comments from the review on Reviewable.io

@RisingFog
Copy link
Member

This PR needs to be rebased.

@lioncash
Copy link
Member Author

lioncash commented Jan 2, 2017

Most of these changes have been done through recent changes to the DSP code, so I'll be closing this.

@lioncash lioncash closed this Jan 2, 2017
@lioncash lioncash deleted the dsp branch January 25, 2017 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants