DQt2: Emulation MenuBar #3646
DQt2: Emulation MenuBar #3646
Conversation
|
I think I kept the Play and Pause buttons separate because one was slightly larger than the other so they shifted stuff around a couple pixels when I swapped one for the other. Is that still the case? |
|
Looks fine on my end. Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
|
Fine with me, then. Anyway it's an easy change if enough people complain. |
rukai
force-pushed
the
dolphinQtEmulationMenu
branch
2 times, most recently
from
59593af
to
3fd1f23
Compare
| int slot = i + 1; | ||
| QString info = QString::fromStdString(State::GetInfoStringOfSlot(slot)); | ||
| QString action_string = QStringLiteral(" Slot %1 - %2").arg(slot).arg(info); | ||
| actions_load.at(i)->setText(QStringLiteral("Load from") + action_string); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
rukai
force-pushed
the
dolphinQtEmulationMenu
branch
from
3fd1f23
to
400be73
Compare
| m_fullscreen_action->setEnabled(true); | ||
| m_screenshot_action->setEnabled(true); | ||
| } | ||
|
|
||
| void ToolBar::EmulationPaused() | ||
| { | ||
| m_play_action->setEnabled(true); | ||
| { m_play_action->setEnabled(true); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
rukai
force-pushed
the
dolphinQtEmulationMenu
branch
from
400be73
to
6ddeb18
Compare
|
Source/Core/DolphinQt2/MainWindow.cpp, line 323 [r3] (raw file): Comments from the review on Reviewable.io |
|
Reviewed 4 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3. Comments from the review on Reviewable.io |
rukai
force-pushed
the
dolphinQtEmulationMenu
branch
from
6ddeb18
to
ac6d542
Compare
|
LGTM |
| @@ -15,19 +15,71 @@ class MenuBar final : public QMenuBar | |||
| explicit MenuBar(QWidget* parent = nullptr); | |||
|
|
|||
| signals: | |||
| //File | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
rukai
force-pushed
the
dolphinQtEmulationMenu
branch
from
ac6d542
to
6964b1d
Compare
| QAction* action; | ||
| for (int i = 1; i <= 10; i++) | ||
| { | ||
| action = m_state_load_slots_menu->addAction(QStringLiteral("")); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
rukai
force-pushed
the
dolphinQtEmulationMenu
branch
from
6964b1d
to
cc6a782
Compare
Save states, fullscreen, frame advance, screenshot and emulation controls are available through the MenuBar
Emulation menubar includes save states, fullscreen, frame advance, screenshot and emulation controls.
Also included in this PR is combining the pause and start button into the same slot in the toolbar