NonCopyable: Minor changes #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't necessary, as the member functions are deleted. If someone tries to perform a copy, the compiler will now indicate that the member functions/constructors are deleted, rather than inaccessible.
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler auto-generates the copy constructor/assignment functions with const qualified parameters, so we should specify those instead.
Also, this removes the private access specifier, since this isn't necessary, as the members are deleted. This will also change the compiler error on attempted copies to indicate that the constructor/member function is deleted, rather than inaccessible.
This change is