CoreTiming: Trim max slicelength to the given value.

[phire]

Previously it was underclocking by 50% when there were no events to schedule.

---

This change is

[phire]

Cherry-picked from #3716

[degasus]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Source/Core/Core/CoreTiming.cpp, line 428 [r1] (raw file):
Does any event access g_slicelength or ppcState.downcount? If not, what do you think about moving this line before if (first)?

---

Comments from the review on Reviewable.io

[phire]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Source/Core/Core/CoreTiming.cpp, line 428 [r1] (raw file):
There should be no need to access either while globalTimer is sane.

---

Comments from the review on Reviewable.io

[degasus]

Do you think this should be within 5.0?

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• rs3-bumpmapping on ogl-lin-intel: diff
• sadx-ui on ogl-lin-intel: diff
• smg2-fog on ogl-lin-intel: diff
• sms-bubbles on ogl-lin-intel: diff
• sonic-riders-blur on ogl-lin-intel: diff

_{^{automated-fifoci-reporter}}

[degasus]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[degasus]

ping?

[phire]

Yeah, merge it.