Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Framestop Functions #3769

Merged
merged 2 commits into from
Apr 29, 2016

Conversation

RisingFog
Copy link
Member

These weren't actually being used for anything, so it only makes sense to remove them.


This change is Reviewable

@degasus
Copy link
Member

degasus commented Apr 5, 2016

As this was the last writing usage of PowerPC::GetStatePtr(), might you change it's definition to return a const pointer?
Else, LGTM

@degasus
Copy link
Member

degasus commented Apr 25, 2016

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@degasus
Copy link
Member

degasus commented Apr 25, 2016

IMO ready for 5.0

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@lioncash lioncash added this to the Dolphin Release 5.0 milestone Apr 29, 2016
@lioncash lioncash merged commit b420abc into dolphin-emu:master Apr 29, 2016
@RisingFog RisingFog deleted the remove_framestep branch April 30, 2016 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants