ChunkFile: Handle bool in a stable way across platforms #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bool is not always guaranteed to be the same size on every platform. On some platforms it may be one byte, on others it can be 8 bytes if the platform dictates it. It's implementation-defined. This can be problematic when it comes to storing this data to disk (it can also be space-inefficient, but that's not really an issue). Also say for some reason you moved your savestates to another platform, it's possible they won't load correctly due to differences in size. This change stores all bools to savestates as if they were a byte in size and handles the loading of them accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool is not always guaranteed to be the same size on every platform. On some platforms it may be one byte, on others it can be 8 bytes if the platform dictates it; it's implementation-defined.
This can be problematic when it comes to storing this data to disk (it can also be space-inefficient, but that's not really an issue in 2016). Also say for some reason you moved your savestates to another platform, it's possible they won't load correctly due to differences in size.
This change stores all bools to savestates as if they were a byte in size and handles the loading of them accordingly.
This was brought up by myself in #3759, and @delroth recommended that this be included within 5.0, so here it is.
This change is