Update Windows build instructions and .gitignore #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git has been required for a long time, and we also have two more recent requirements.
| @@ -18,6 +18,8 @@ Source/Core/Common/scmrev.h | |||
| *.vcxproj.user | |||
| *.obj | |||
| *.tlog | |||
| *.VC.opendb | |||
| *.VC.db | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JosJuice
force-pushed
the
windows-build-instructions
branch
from
4836a98
to
91a95cd
Compare
|
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. .gitignore, line 22 [r1] (raw file): Comments from Reviewable |
|
Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Comments from Reviewable |
|
You don't need to install the Windows 10 SDK manually. You just need to check the "Universal Windows App Development Tools" option in the Visual Studio installer. |
|
Yes, but that doesn't change the fact that the Windows 10 SDK needs to be installed. Installing it during the Visual Studio installation process is just a different way of installing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is