XInput: Apply Rumble/Motor output only on changes (again) #3790
Conversation
|
I tested this, fixes the xbox one controller rumble (as wiimote) I also tested a 360 controller and that still works. |
|
@mimimi085181: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. @mimimi085181: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. @mimimi085181: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. Amazing, thanks for tracking this down! Feel free to merge whenever you think enough testing has been done. @dolphin-emu-bot allowmerge |
| @@ -90,7 +90,7 @@ class Device : public Core::Device | |||
|
|
|||
| private: | |||
| XINPUT_STATE m_state_in; | |||
| XINPUT_VIBRATION m_state_out; | |||
| XINPUT_VIBRATION m_state_out, m_current_state_out; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mimimi085181
force-pushed
the
fix-xbox-one-rumble-test1
branch
from
cc9df1c
to
48ae041
Compare
|
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Disclaimer: I can't test if this works on xbox one controllers, i don't have one. But i have conformed that this UpdateMotors() is related to rumble for emulated wiimotes. This partially reverts commit "XInput: Apply immediately as well" (1958a10) from pr # dolphin-emu#1560 Hopefully this fixes the xbox one controller rumble issue: https://bugs.dolphin-emu.org/issues/9071 And in theory it might reduce the used usb bandwidth, as it was originally intended before pr 1560. @JMC47: Please do a good amount of testing, to see if this breaks rumble for wiimotes or gamecube controllers emulated with xinput devices.
mimimi085181
force-pushed
the
fix-xbox-one-rumble-test1
branch
from
48ae041
to
fcd5170
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. Source/Core/InputCommon/ControllerInterface/XInput/XInput.h, line 93 [r1] (raw file): Comments from Reviewable |
Disclaimer: I can't test if this works on xbox one controllers, i don't have one. But i have confirmed that this UpdateMotors() is related to rumble for emulated wiimotes.
This partially reverts commit "XInput: Apply immediately as well" (1958a10) from pr # #1560
Hopefully this fixes the xbox one controller rumble issue:
https://bugs.dolphin-emu.org/issues/9071
And in theory it might reduce the used usb bandwidth, as it was originally intended before pr 1560.
@JMC47: Please do a good amount of testing, to see if this breaks rumble for wiimotes or gamecube controllers emulated with xinput devices.
This change is