Fix handling of Wii NAND's /tmp directory during savestate loads. #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (p.GetMode() == PointerWrap::MODE_READ) | ||
| { | ||
| // We need to make sure all file handles are closed so WII_IPC_Devices_fs::DoState can successfully re-create /tmp | ||
| for (u32 i = 0; i<IPC_MAX_FDS; i++) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fixes Metroid prime crashing the second boot after loading a save state (issue 9496)
Because the file handles were open, the recursive delete was failing. The previous commit stopped the crash but this should make the restore actually happen has expected.
|
Reviewed 2 of 2 files at r2. Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. Source/Core/Core/IPC_HLE/WII_IPC_HLE.cpp, line 276 [r1] (raw file): Comments from Reviewable |
|
This PR added four extra DLLs to the Windows download that weren't there before. Was that intentional? |
|
This PR added no DLLs. That'd be correlation not causation for ya. |
|
I mean 4.0-9257 compared to 4.0-9254. |
phire
added a commit
to phire/dolphin
that referenced
this pull request
May 29, 2016
Donkey Kong Country Returns is writing new data to some files in /tmp when loading each level. But the savestate code was opening the files a second time and reading some old and stale data out. As of dolphin-emu#3798, dolphin now correctly restores that stale data to /tmp, which broke DKCR (and probally countless other games). This PR closes all file handles before saving and loading savestates, which flushes the data out and pervents this issue. (old savestates are corrupted and will still cause crashes if loaded)
phire
added a commit
to phire/dolphin
that referenced
this pull request
May 29, 2016
Donkey Kong Country Returns is writing new data to some files in /tmp when loading each level. But the savestate code was opening the files a second time and reading some old and stale data out. As of dolphin-emu#3798, dolphin now correctly restores that stale data to /tmp, which broke DKCR (and probally countless other games). This PR closes all file handles before saving and loading savestates, which flushes the data out and pervents this issue. (old savestates are corrupted and will still cause crashes if loaded)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 9496 and potentially other issues with savestates and wii games.
This change is