Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Remove browse toolbar button and tweak empty gamelist message #3801

Merged
merged 1 commit into from May 8, 2016

Conversation

Helios747
Copy link
Contributor

@Helios747 Helios747 commented Apr 27, 2016

This would have been a 20 minute PR but fuck Windows 10's SDK.

image

Fixes blocker: https://bugs.dolphin-emu.org/issues/9500


This change is Reviewable

@@ -544,7 +544,6 @@ void CFrame::PopulateToolbar(wxToolBar* ToolBar)

WxUtils::AddToolbarButton(ToolBar, wxID_OPEN, _("Open"), m_Bitmaps[Toolbar_FileOpen], _("Open file..."));
WxUtils::AddToolbarButton(ToolBar, wxID_REFRESH, _("Refresh"), m_Bitmaps[Toolbar_Refresh], _("Refresh game list"));
WxUtils::AddToolbarButton(ToolBar, IDM_BROWSE, _("Browse"), m_Bitmaps[Toolbar_Browse], _("Browse for an ISO directory..."));

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@Helios747 Helios747 force-pushed the the_30_minute_blocker_fix branch 3 times, most recently from c445ad1 to a8eb3e3 Compare April 30, 2016 02:09
@JosJuice
Copy link
Member

Reviewed 1 of 2 files at r1, 2 of 4 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@JosJuice
Copy link
Member

JosJuice commented May 7, 2016

Reminder: The string freeze is in 41 hours. If this PR's string change isn't merged before then, it can't get into 5.0.

@MayImilae
Copy link
Contributor

@delroth are you fine with merging this before 5.0?

@JosJuice
Copy link
Member

JosJuice commented May 8, 2016

Less than 3 hours left!

@lioncash lioncash merged commit c299a6a into dolphin-emu:master May 8, 2016
@lioncash lioncash added this to the Dolphin Release 5.0 milestone May 8, 2016
@Helios747 Helios747 deleted the the_30_minute_blocker_fix branch October 8, 2016 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants