[WIP] Add a large, hacky delay to AX HLE so NeoGeo games work. #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm guessing the game changes the memory after sending the command list to the DSP.
|
Nice proove to just require LLE. |
|
Or we could merge this obviously accurate hardware tested fix? |
|
Yeah, Forcing LLE is probably a better idea. Adding accurate timing to HLE (an appropriate delay between each command in the command list) would slow it down close to LLE speeds. @delroth, any comment? |
|
Why would it slow down? Wouldn't it just change when the code is executed, but not how much? Or is it the threading code causing a slowdown? |
|
This loop would get split out over multiple events. The overhead of slowing down and processing those events and rapidly switching between the JIT and DSPLLE would slow things down, along with cache effects. |
|
Closed in favour of #3841 HLE shouldn't be trying to emulate this correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing the game changes the memory after sending the command list to the DSP.
"Fixes" Issue 9315, but I'm not sure if this is a good idea.
This change is