New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force Neo Geo games to use LLE Audio #3841
Conversation
@Linktothepast feel free to review this |
7d93267
to
f1a8d52
Compare
You should force DSP JIT too, otherwise people might end up with LLE interpreter depending on what their DSP JIT setting is. |
DSP JIT is the default. I don't see why we should enfore it by game inis. |
We used to force DSP JIT for all INIs that forced DSP LLE (until we stopped having any INIs with forced DSP LLE). I'm assuming it was because of something like it being possible to have DSPHLE = True, DSPJIT = False in the general config if LLE interpreter was selected before HLE. If that's not true, and DSPJIT always is True when HLE is enabled, then I do agree we shouldn't force DSP JIT. |
Using DSP-LLE on these games is a small performance hit (~10%) so this is fine with me. Still over 300 FPS. |
Review status: 0 of 74 files reviewed at latest revision, 2 unresolved discussions. Data/Sys/GameSettings/EA2.ini, line 9 [r2] (raw file):
When DSP-LLE doesn't cause severe issues (like, making a game unreasonable demanding) I think the games that are tested should still be rated as Perfect. This is kind of unrelated to the pull request but it just caught my eye. Data/Sys/GameSettings/EA2.ini, line 21 [r2] (raw file):
Is this lack of new line thing an issue? Comments from Reviewable |
Reviewed 73 of 73 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. Data/Sys/GameSettings/EA2.ini, line 9 [r2] (raw file):
|
Data/Sys/GameSettings/EA2.ini, line 21 [r2] (raw file):
|
Review status: all files reviewed at latest revision, 2 unresolved discussions. Data/Sys/GameSettings/EA2.ini, line 9 [r2] (raw file):
|
|
These two games were missed in PR dolphin-emu#3841.
This implicitly forces DSPLLE for two more games that were missed in PR dolphin-emu#3841: - The King of Fighters '98 (ECHxJ8) - Tokuten Oh: Honoo no Libero (ECMJJ8)
Another fix for issue 9315.
This change is