Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Neo Geo games to use LLE Audio #3841

Merged
merged 2 commits into from May 18, 2016

Conversation

RisingFog
Copy link
Member

@RisingFog RisingFog commented May 14, 2016

Another fix for issue 9315.


This change is Reviewable

@RisingFog
Copy link
Member Author

@Linktothepast feel free to review this

@JosJuice
Copy link
Member

You should force DSP JIT too, otherwise people might end up with LLE interpreter depending on what their DSP JIT setting is.

@degasus
Copy link
Member

degasus commented May 14, 2016

DSP JIT is the default. I don't see why we should enfore it by game inis.

@JosJuice
Copy link
Member

We used to force DSP JIT for all INIs that forced DSP LLE (until we stopped having any INIs with forced DSP LLE). I'm assuming it was because of something like it being possible to have DSPHLE = True, DSPJIT = False in the general config if LLE interpreter was selected before HLE. If that's not true, and DSPJIT always is True when HLE is enabled, then I do agree we shouldn't force DSP JIT.

@JMC47
Copy link
Contributor

JMC47 commented May 15, 2016

Using DSP-LLE on these games is a small performance hit (~10%) so this is fine with me. Still over 300 FPS.

@JMC47
Copy link
Contributor

JMC47 commented May 15, 2016

Review status: 0 of 74 files reviewed at latest revision, 2 unresolved discussions.


Data/Sys/GameSettings/EA2.ini, line 9 [r2] (raw file):

[EmuState]
# The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 4

When DSP-LLE doesn't cause severe issues (like, making a game unreasonable demanding) I think the games that are tested should still be rated as Perfect. This is kind of unrelated to the pull request but it just caught my eye.


Data/Sys/GameSettings/EA2.ini, line 21 [r2] (raw file):

# Add action replay cheats here.

[Video_Settings]

Is this lack of new line thing an issue?


Comments from Reviewable

@JMC47
Copy link
Contributor

JMC47 commented May 18, 2016

Reviewed 73 of 73 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@JMC47
Copy link
Contributor

JMC47 commented May 18, 2016

Review status: all files reviewed at latest revision, 2 unresolved discussions.


Data/Sys/GameSettings/EA2.ini, line 9 [r2] (raw file):

Previously, JMC47 wrote…

When DSP-LLE doesn't cause severe issues (like, making a game unreasonable demanding) I think the games that are tested should still be rated as Perfect. This is kind of unrelated to the pull request but it just caught my eye.

This comment is really unrelated to the Pull Request and I regret making it. I don't know how to delete it though.

Comments from Reviewable

@RisingFog
Copy link
Member Author

Data/Sys/GameSettings/EA2.ini, line 21 [r2] (raw file):

Previously, JMC47 wrote…

Is this lack of new line thing an issue?

it shouldn't be

Comments from Reviewable

@JosJuice
Copy link
Member

Review status: all files reviewed at latest revision, 2 unresolved discussions.


Data/Sys/GameSettings/EA2.ini, line 9 [r2] (raw file):

Previously, JMC47 wrote…

This comment is really unrelated to the Pull Request and I regret making it. I don't know how to delete it though.

I don't think you can delete it, but what you can do is press the circle thing at the bottom-right corner of the comment field and change the status to Satisfied so it doesn't count as an unresolved discussion anymore.

Comments from Reviewable

@degasus
Copy link
Member

degasus commented May 18, 2016

:lgtm:

Previously, JMC47 wrote…

Using DSP-LLE on these games is a small performance hit (~10%) so this is fine with me. Still over 300 FPS.


Reviewed 74 of 74 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@degasus degasus merged commit e11b884 into dolphin-emu:master May 18, 2016
@RisingFog RisingFog deleted the neogeo_force_lle branch June 2, 2016 16:17
Tilka added a commit to Tilka/dolphin that referenced this pull request Aug 13, 2021
Tilka added a commit to Tilka/dolphin that referenced this pull request Aug 13, 2021
This implicitly forces DSPLLE for two more games that were missed in PR dolphin-emu#3841:
- The King of Fighters '98 (ECHxJ8)
- Tokuten Oh: Honoo no Libero (ECMJJ8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants