[Android] Reduce code redundancy and catch a leak #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 18, 2016 22:10
Apply is asynchronous, and we aren't expecting a return value so there is no reason not to use apply.
And fix deprecation warning in script
|
@dolphin-emu-bot rebuild |
|
Sounds like a nice cleanup. @sigmabeta ?
|
|
Reviewed 13 of 13 files at r1. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
@Tsunamical A regression was reported. Could you look into it? https://bugs.dolphin-emu.org/issues/9560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the previous cleanup PRs without the dependency update or stylistic changes. Because Android Studio 2.1.0 is out, we can shift the gradle plugin to it as it is in the stable line.
This change is