Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Reduce code redundancy and catch a leak #3849

Merged
merged 5 commits into from
May 19, 2016
Merged

[Android] Reduce code redundancy and catch a leak #3849

merged 5 commits into from
May 19, 2016

Commits on May 19, 2016

  1. [Android] Fix possible leak of fileCursor

    Tyler Dunn committed May 19, 2016
    Configuration menu
    Copy the full SHA
    6a870c2 View commit details
    Browse the repository at this point in the history

  2. [Android] Don't hardcode SD card path

    Tyler Dunn committed May 19, 2016
    Configuration menu
    Copy the full SHA
    a0b54f5 View commit details
    Browse the repository at this point in the history

  3. [Android] Drop commit() for apply() 

    Apply is asynchronous, and we aren't expecting a return value so there
is no reason not to use apply.
    Tyler Dunn committed May 19, 2016
    Configuration menu
    Copy the full SHA
    937caea View commit details
    Browse the repository at this point in the history

  4. [Android] Reduce code redundancy

    Tyler Dunn committed May 19, 2016
    Configuration menu
    Copy the full SHA
    a5b72ab View commit details
    Browse the repository at this point in the history

  5. [Android] Bump gradle plugin to 2.1.0 

    And fix deprecation warning in script
    Tyler Dunn committed May 19, 2016
    Configuration menu
    Copy the full SHA
    4a0a92e View commit details
    Browse the repository at this point in the history