Split Audio Dumps on Sample Rate Changes

[RisingFog]

This is somewhat of a port of the dolphin-avsync functionality of splitting audio files based on sample rate changes. It's also an alternative to PR #3542, which would resample all audio to 48khz.

---

This change is

[lioncash]

Review status: 0 of 4 files reviewed at latest revision, 5 unresolved discussions.

---

Source/Core/AudioCommon/Mixer.h, line 60 [r2] (raw file):

      unsigned int Mix(short* samples, unsigned int numSamples, bool consider_framelimit = true);
      void SetInputSampleRate(unsigned int rate);
      unsigned int GetInputSampleRate();

This can be const qualified

---

Source/Core/AudioCommon/WaveFile.cpp, line 113 [r2] (raw file):

  }

  if (sample_rate != current_sample_rate)

This and the code below should be extracted to their own function. This literally do the same thing

---

Comments from Reviewable

[RisingFog]

Review status: 0 of 4 files reviewed at latest revision, 5 unresolved discussions.

---

Source/Core/AudioCommon/Mixer.h, line 60 [r2] (raw file):

Previously, lioncash (Mat M.) wrote…

This can be const qualified

Done.

---

Source/Core/AudioCommon/WaveFile.cpp, line 45 [r1] (raw file):

Previously, BhaaLseN (BhaaL) wrote…

My bad. /me hides

You could look into using StringUtil::SplitPath tho.

Done.

---

Source/Core/AudioCommon/WaveFile.cpp, line 113 [r2] (raw file):

Previously, lioncash (Mat M.) wrote…

This and the code below should be extracted to their own function. This literally do the same thing

Done.

---

Comments from Reviewable

[lioncash]

Source/Core/AudioCommon/Mixer.h, line 60 [r2] (raw file):

Previously, RisingFog (Chris Burgener) wrote…

Done.

I had meant like:

unsigned int GetInputSampleRate() const;

---

Comments from Reviewable

[RisingFog]

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

---

Source/Core/AudioCommon/Mixer.h, line 60 [r2] (raw file):

Previously, lioncash (Mat M.) wrote…

I had meant like:

unsigned int GetInputSampleRate() const;

Done.

---

Comments from Reviewable

[degasus]

---

Reviewed 4 of 4 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Source/Core/AudioCommon/WaveFile.cpp, line 122 [r5] (raw file):

}

void WaveFileWriter::AddStereoSamplesBE(const short* sample_data, u32 count, int sample_rate)

IMO AddStereoSamplesBE and AddStereoSamples should be merged, but this should be done in the next PR.

---

Comments from Reviewable