GameIni: Force LLE Audio on Star Wars Rogue Squadron II & III #3919
Conversation
Force LLE audio output on all Star Wars: Rogue Leader releases in order to fix the constant glitchy noise audio ouput.
Catarax
changed the title
|
This is probably a good idea.
|
|
If this is being done, it should be done with RS3 as well. |
|
I'll do it for the other episode if merged, yes. |
Force LLE audio output on all Star Wars Rogue Squadron III: Rebel Strike releases in order to fix the constant glitchy noise audio ouput.
Catarax
changed the title
|
Fix added for Rogue Squadron III. |
|
As we talked about this on IRC, the issue with this is that there is no way for a user to override this - LLE and HLE have to be chosen before the game is run, so there is no way to override this while the game is running. And the only way to override it is to edit the gameini and remove the feature, which is something we don't really want users doing! So it might be a good idea to just wait for a proper fix, instead of covering it up like this. |
|
You can turn it off via the game properties page? |
|
I'm iffy on the issue as well. I do not want to encourage users to "get extra speed" by opening things while running to change a setting. This is already enough of a problem with the graphics settings. On the other hand, this is awful, holy crap! I just tested the game and BGM entirely kills it. soooo.... meh meh meh meh meh mehhhhhhhhh. Maybe if this was after 5.0 I'd be fine with it? I don't care what happens to perf then. |
|
@Helios747 Why don't we make this simple by having there be a checkbox that says "Use Default Game Settings" at the top of the settings menu so that it doesn't automatically switch to the other settings when you open up the menu? |
|
I don't think that is a bad idea, but it'll be bikeshed to hell. Oh wait, I misunderstood what you meant. I'd rather just fix the config system and rework the UI than do that. |
|
@Helios747 I agree that there probably is a better solution, but I think having a checkbox for that is a good idea. The current system of hidden default settings via the INIs and the fact that the INIs are overwritten when you open up the settings is extremely unintuitive for new users and even people that actually understand what is going on. Because currently, even if you do override the default settings, there is no way to go back (unless there is... I don't know, like I said, it is not an intuitive system for anyone). A checkbox that could be toggled on and off would be very useful and visual. Maybe with some mouseover text that reads "Many games have been tested for a set of optimized settings, this box will enable those settings and ignore the manual settings." Maybe the rest of the settings could be grayed out and not interactable unless the check box is off. A final note, to increase user friendliness, there should be some place to easily see what the default settings are. |
|
If we didn't have a config rewrite in the works, I would consider this, but this idea is just a bandaid. A bandaid we don't really need anymore. |
|
Are we really concerned that there will be no way to for the user to enable the option that Damages their hearing. That sounds like a feature to me. |
|
phire, I'm sure you're very aware of some of the insane lengths our users will go to go fast. |
|
Yes, and they are welcome to edit the config files. |
|
@Helios747 Fair enough. But the new config system is still a ways off, is it not? (Although, even something as minor as my patch idea wouldn't get into 5.0 at this point.) |
|
I'm personally neutral toward this. I think having it emulate accurately, but slowly, by default is the slightly more sane option. |
|
True.
haha nvm you can't change backends when running anyways
This will absolutely destroy performance though. @Fallcrest Depends on when @mathieui rebases it again and addresses a silly naming issue. But it's done. It addresses the problem at hand by not having every UI selected setting override GameINI whenever the user opens a menu. As well as cleaning up a lot of bandaids in code. |
|
@Helios747 What PR is the new configuration system? I can't find a single PR ever made by mathieui. There is a new configuration system PR by Sonicadvance1. (Okay, yeah, I found it, sorry. It would not let me search by mathieui's name, for some reason. When I typed it into filter by author, nothing showed up...) |
|
Did some testing since we have analytics now on a 4790k (Most popular CPU) and a 4700MQ (25th most popular CPU) Tests done against the first mission at 1x IR 4790k: HLE: LLE: 4700MQ (averaged 3 ghz): HLE: LLE: I'm not sure why LLE didn't hit my 4700MQ as hard. But yeah. This is something to consider. If trends continue after 5.0 and my CPU remains the most popular? This is a no-brainer and we should totally do this. If 5.0 brings in the flood of AMD trash CPUs, they may prefer to just turn off BGM. (which, honestly, we can just have them check HLE audio in game properties) |
|
For RS2, we could probably get back some of the performance with turning off EFB2RAM. It's not needed for the targeting computer any more. It's only needed for some special effects... none of which are game breaking. But, maybe it'd be best to leave that on for now. |
|
Reviewed 1 of 1 files at r1, 1 of 1 files at r2. Comments from Reviewable |
|
I think that should set this. |
|
To quote @lioncash I like how this comes roaring into existence after we merge the PR. |
Force LLE audio output on all Star Wars: Rogue Squadron releases in order to fix the constant glitchy noise audio ouput.
This change is