Split Video Dumps on Resolution Change

[RisingFog]

Also handles widescreen changes.

---

This change is

[lioncash]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

Source/Core/VideoCommon/AVIDump.cpp, line 48 [r1] (raw file):

static bool s_start_dumping = false;
static u64 s_last_pts;
static int current_width;

s_

---

Source/Core/VideoCommon/AVIDump.cpp, line 171 [r2] (raw file):

{
  if (width != current_width || height != current_height)
  {

This should go in its own function. This doesn't have anything to do with directly adding a new frame (particularly considering it stops and then starts a new video).

---

Comments from Reviewable

[RisingFog]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

Source/Core/VideoCommon/AVIDump.cpp, line 48 [r1] (raw file):

Previously, lioncash (Mat M.) wrote…

s_

Done.

---

Source/Core/VideoCommon/AVIDump.cpp, line 171 [r2] (raw file):

Previously, lioncash (Mat M.) wrote…

This should go in its own function. This doesn't have anything to do with directly adding a new frame (particularly considering it stops and then starts a new video).

Done.

---

Comments from Reviewable

[RisingFog]

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.

---

Source/Core/VideoCommon/AVIDump.cpp, line 295 [r3] (raw file):

Previously, BhaaLseN (BhaaL) wrote…

Since this is only called here with true as parameter, would it make sense to move the s_file_index change over here?

Done.

---

Comments from Reviewable

[RisingFog]

@dolphin-emu-bot rebuild

[JMC47]

Works correctly in D3D11/12 and OpenGL.

[Helios747]

Reviewed 2 of 6 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[phire]

Reviewed 2 of 6 files at r1, 2 of 6 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

Source/Core/VideoBackends/D3D/Render.cpp, line 920 [r5] (raw file):

      D3D::context->Map(s_screenshot_texture, 0, D3D11_MAP_READ, 0, &map);

      if (frame_data.empty() || source_width != s_recordWidth || source_height != s_recordHeight)

You could simplify this all to just:

if (frame_data.capacity() != 3 * source_width * source_height)
    frame_data.resize(3 * source_width * source_height)

Or swap the != for a < to only resize when frame_data is too small.

Actually, s_recordWidth/Height isn't needed at all anymore, as it's always updated to match source_width and source_height. Delete them.

---

Comments from Reviewable

[RisingFog]

Review status: 2 of 4 files reviewed at latest revision, 5 unresolved discussions.

---

Source/Core/VideoBackends/D3D/Render.cpp, line 920 [r5] (raw file):

Previously, phire (Scott Mansell) wrote…

You could simplify this all to just:

if (frame_data.capacity() != 3 * source_width * source_height)
    frame_data.resize(3 * source_width * source_height)

Or swap the != for a < to only resize when frame_data is too small.

Actually, s_recordWidth/Height isn't needed at all anymore, as it's always updated to match source_width and source_height. Delete them.

Done.

---

Source/Core/VideoBackends/D3D12/Render.cpp, line 896 [r5] (raw file):

Previously, sepalani wrote…

source_height != source_height? Not sure it was intended...

Done.

---

Source/Core/VideoBackends/D3D12/Render.cpp, line 899 [r5] (raw file):

Previously, sepalani wrote…

Ditto.

Done.

---

Comments from Reviewable

[phire]

---

Reviewed 2 of 2 files at r6.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

Comments from Reviewable