Scrubbing improvements

[JosJuice]

Details:
https://forums.dolphin-emu.org/Thread-decompressing-gcz-to-iso-fills-with-0xff
https://bugs.dolphin-emu.org/issues/9356

---

This change is

[lioncash]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

Source/Core/DiscIO/DiscScrubber.cpp, line 180 [r1] (raw file):

  u64 end_offset = offset + size;
  // Calculate the start of the first cluster
  offset = offset / 0x7c00 * CLUSTER_SIZE + partition_data_offset;

This should probably be its own variable, like u64 first_cluster_offset = ... or some other better name instead of reusing a variable with an ambiguous name. (protip: if you need to explain what you are doing in a comment, rather than explaining why, chances are it's dodgy).

---

Comments from Reviewable

[JosJuice]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

Source/Core/DiscIO/DiscScrubber.cpp, line 180 [r1] (raw file):

Previously, lioncash (Mat M.) wrote…

This should probably be its own variable, like u64 first_cluster_offset = ... or some other better name instead of reusing a variable with an ambiguous name. (protip: if you need to explain what you are doing in a comment, rather than explaining why, chances are it's dodgy).

Done.

---

Comments from Reviewable