OpenBSD neither provides nor requires libdl and librt.

[bentley]

Fixes linking errors on OpenBSD.

---

This change is

[Parlane]

@dolphin-emu-bot rebuild

[endrift]

Should maybe make these match all BSD flavors, not just special casing OpenBSD and FreeBSD, since I highly doubt e.g. NetBSD or PC-BSD will be any different.

[Parlane]

@endrift yea that's the only reason I didn't merge. Could the matches just be on "BSD" ?

[bentley]

Matching on “BSD” is not a good strategy in general, as there’s a lot of divergence. Notice how FreeBSD requires librt but not libdl. #4018 shows some other examples of divergence between OpenBSD and FreeBSD: the sysctl interface differs, and OpenBSD doesn't support newlocale().

A better way would be to default to POSIX and only special‐case POSIX‐violating systems. So the librt hunk would stay (because POSIX requires librt, and OpenBSD/OS X violate that), and the libdl hunks would be changed to match only Linux (because POSIX does not require libdl).

[endrift]

Yeah, that's more or less the way I was thinking, although I can't speak for other people here since they care more about Linux than any other *NIX system.

[bentley]

Okay, here’s a new version per the previous comment.

[Parlane]

@dolphin-emu-bot rebuild

[endrift]

Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable