New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openbsd ifdefs #4018
Openbsd ifdefs #4018
Conversation
This one fails our lint test. See the output of this: https://buildbot.dolphin-emu.org/builders/lint/builds/2005/steps/shell/logs/stdio |
Redid the last commit to wrap lines. |
@dolphin-emu-bot rebuild |
Reviewed 5 of 6 files at r1, 1 of 1 files at r2. Comments from Reviewable |
@dolphin-emu-bot rebuild you messed up! |
@dolphin-emu-bot rebuild |
Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion. Source/Core/Core/HW/EXI_DeviceEthernet.h, line 330 [r2] (raw file):
Why did you change these lines? Comments from Reviewable |
I didn’t understand the wrapping rules in the linter. But that’s an old diff; cdf62de is the current one. |
The linter is
|
int fd; | ||
#endif | ||
|
||
#if defined(WIN32) || defined(__linux__) || defined(__APPLE__) || defined(__FreeBSD__) | ||
#if defined(WIN32) || defined(__linux__) || defined(__APPLE__) || defined(__FreeBSD__) || \ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Source/Core/Core/HW/EXI_DeviceEthernet.h, line 334 [r3] (raw file):
|
LGTM Reviewed 1 of 1 files at r3. Comments from Reviewable |
These fix most compilation problems under OpenBSD.
This change is