Clean up context definition errors. #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no context definition in a non-generic build, compilation will error out anyway, but in a less obvious place.
If the #error hits, the operating system may be fine but the architecture won't be.
|
Nice changes so far with regards to OpenBSD. As a rule of thumb for the future, if a change is small, it'd be helpful if there was indication of where a change was being made in the title. For example, |
|
@dolphin-emu-bot rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fallback error condition when no context is defined. If there is no context definition in a non-generic build, compilation will error out anyway, but in a less obvious place.
Then define a context for OpenBSD amd64.
This change is