Remove Global Declarations from Movie

[RisingFog]

Removes all global declarations from Movie, and replaces them with getters and setters.

---

This change is

[lioncash]

Review status: 0 of 10 files reviewed at latest revision, 2 unresolved discussions.

---

Source/Core/Core/Movie.cpp, line 413 [r1] (raw file):

}

void SetClearSave(bool bEnabled)

the parameters can just be regularly snake-cased like enabled, disc_changed, etc.

---

Source/Core/Core/Movie.cpp, line 433 [r1] (raw file):

}

void SetDiscChange(std::string sDiscChange)

This should probably take the string by const reference.

The naming also seems somewhat ambiguous here (not like the variables weren't, really). Considering there's already a function named SetChangedDisc

You may want to combine these into one and make it just do something like

void SignalDiscChange(const std::string& new_disc_filename)
{
  s_bDiscChange = true;
  s_discChange = new_disc_filename;
}

Since they're only ever used in conjunction with one another.

---

Comments from Reviewable

[RisingFog]

Review status: 0 of 10 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

---

Source/Core/Core/Movie.cpp, line 413 [r1] (raw file):

Previously, lioncash (Mat M.) wrote…

the parameters can just be regularly snake-cased like enabled, disc_changed, etc.

Done.

---

Source/Core/Core/Movie.cpp, line 433 [r1] (raw file):

Previously, lioncash (Mat M.) wrote…

This should probably take the string by const reference.

The naming also seems somewhat ambiguous here (not like the variables weren't, really). Considering there's already a function named SetChangedDisc

You may want to combine these into one and make it just do something like

void SignalDiscChange(const std::string& new_disc_filename)
{
  s_bDiscChange = true;
  s_discChange = new_disc_filename;
}

Since they're only ever used in conjunction with one another.

Done.

---

Comments from Reviewable

[lioncash]

Source/Core/Core/Movie.cpp, line 421 [r3] (raw file):

{
  s_discChange = new_disc_filename;
  s_bDiscChange = true;

There's tabs instead of spaces here.

---

Comments from Reviewable

[RisingFog]

Source/Core/Core/Movie.cpp, line 421 [r3] (raw file):

Previously, lioncash (Mat M.) wrote…

There's tabs instead of spaces here.

Done.

---

Comments from Reviewable

[lioncash]

Reviewed 7 of 10 files at r1, 2 of 3 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable