Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Global Declarations from Frame #4089

Merged
merged 1 commit into from Aug 4, 2016

Conversation

RisingFog
Copy link
Member

@RisingFog RisingFog commented Aug 4, 2016

Removes the save slot global declaration from Frame, and replaces it with a getter and a setter.


This change is Reviewable

@lioncash
Copy link
Member

lioncash commented Aug 4, 2016

Source/Core/DolphinWX/Frame.cpp, line 69 [r1] (raw file):

#include "VideoCommon/VideoConfig.h"

static int s_saveSlot = 1;

Unless I've misread anything, this can just be made a private member variable of the CFrame class.


Comments from Reviewable

@RisingFog
Copy link
Member Author

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


Source/Core/DolphinWX/Frame.cpp, line 69 [r1] (raw file):

Previously, lioncash (Mat M.) wrote…

Unless I've misread anything, this can just be made a private member variable of the CFrame class.

Done.

Comments from Reviewable

@lioncash
Copy link
Member

lioncash commented Aug 4, 2016

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@lioncash lioncash merged commit d6df861 into dolphin-emu:master Aug 4, 2016
@RisingFog RisingFog deleted the remove_globals_saveslot branch August 4, 2016 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants