Map: Prevents symbols from being stripped #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I know, there is no good reason to strip symbol names. |
leoetlino
added a commit
to leoetlino/dolphin
that referenced
this pull request
Sep 26, 2016
This changes GetSymbolFromName to only require an exact match when the passed name is "complete" (i.e. it contains more than just the function name). When the passed name only contains a function name, it is assumed that we only want to check if the function name contains the passed name. This fixes a regression introduced by dolphin-emu#4160, which prevented HLE::PatchFunctions() from working properly.
leoetlino
added a commit
to leoetlino/dolphin
that referenced
this pull request
Sep 26, 2016
This changes GetSymbolFromName to not require the passed name to completely match with the symbol name. Instead, we now match against the stripped symbol name (i.e. only the function name). This fixes a regression introduced by dolphin-emu#4160, which prevented HLE::PatchFunctions() from working properly.
leoetlino
added a commit
to leoetlino/dolphin
that referenced
this pull request
Sep 26, 2016
This changes GetSymbolFromName to not require the passed name to completely match with the symbol name. Instead, we now match against the stripped symbol name (i.e. only the function name). This fixes a regression introduced by dolphin-emu#4160, which prevented HLE::PatchFunctions() from working properly.
leoetlino
added a commit
to leoetlino/dolphin
that referenced
this pull request
Sep 26, 2016
This changes GetSymbolFromName to not require the passed name to completely match with the symbol name. Instead, we now match against the stripped symbol name (i.e. only the function name). This fixes a regression introduced by dolphin-emu#4160, which prevented HLE::PatchFunctions() from working properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol maps can contain C++ mangled symbols. Demangling them with c++filt works, but Dolphin strips the whole function prototype and only keeps the name. Overloaded function can't be differentiated when demangled as well. This also prevents to manually complete function prototypes.
Is there any good reason to strip symbol's name?
EDIT: Zelda TP symbol map uses (not mangled) C++ symbols and valuable prototype informations are in there.
This change is