Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPCDebugInterface: Let ToggleMemCheck create the first memcheck #4217

Merged
merged 1 commit into from Oct 2, 2016

Conversation

EmptyChaos
Copy link
Contributor

@EmptyChaos EmptyChaos commented Sep 15, 2016

ToggleMemCheck fails to create a new memcheck if there isn't already an existing one which seems like an unnecessary limitation that prevents CMemoryView from being able to create memory checks without adding one via the breakpoint tool window first.


This change is Reviewable

@lioncash
Copy link
Member

Source/Core/Core/Debugger/PPCDebugInterface.cpp, line 140 at r1 (raw file):

bool PPCDebugInterface::IsMemCheck(unsigned int address)
{
  return !!PowerPC::memchecks.GetMemCheck(address);

!= nullptr. It actually enforces the comparison type as a pointer.


Comments from Reviewable

ToggleMemCheck fails to create a memcheck if one doesn't already
exist.
@EmptyChaos
Copy link
Contributor Author

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


Source/Core/Core/Debugger/PPCDebugInterface.cpp, line 140 at r1 (raw file):

Previously, lioncash (Mat M.) wrote…

!= nullptr. It actually enforces the comparison type as a pointer.

Done.

Comments from Reviewable

@lioncash lioncash merged commit f292df2 into dolphin-emu:master Oct 2, 2016
@EmptyChaos EmptyChaos deleted the toggle-memcheck branch October 3, 2016 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants