Shut down Wii software gracefully #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Virtual Console titles indefinitely hang on "attempting shutdown" for right now. |
|
@JMC47 does that only happen with VC titles? |
|
This should now be fixed. |
leoetlino
force-pushed
the
stm-shutdown
branch
3 times, most recently
from
7a80037
to
591eebe
Compare
|
Fixes saving in NES VC/SNES VC games. |
There was as far as I know no reason to put everything in the header. Separating the declaration from the implementation reduces build times in case the implementation is updated without changing any declaration.
Switches to the new naming conventions.
This adds support for triggering the power event (in the STM), so that stopping emulation first triggers a shutdown event, which notably gives emulated software time to save game data (issue 8979) and clean up SYSCONF (to disconnect Wiimotes and update their state in the SYSCONF). On the first press, the stop button/hotkey/whatever will trigger a STM power event. On a second try, we will forcefully stop emulation, just like how it was working before.
When standby mode is enabled, this causes games to ES_Launch the system menu instead of directly asking IOS (the STM more precisely) to shut down, which prevents graceful shutdown from working (it'll appear to hang). Dolphin never supported WC24 standby mode anyway, so this shouldn't cause any issues. (This should be reverted if and when WC24 standby is implemented…)
leoetlino
force-pushed
the
stm-shutdown
branch
from
591eebe
to
453c4a4
Compare
|
lgtm |
shuffle2
reviewed
Oct 3, 2016
| // Disable WiiConnect24's standby mode. If it is enabled, it prevents us from receiving | ||
| // shutdown commands in the State Transition Manager (STM). | ||
| // TODO: remove this if and once Dolphin supports WC24 standby mode. | ||
| SConfig::GetInstance().m_SYSCONF->SetData("IPL.IDL", 0x00); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This PR is likely the cause of Issue #9819 (Dolphin crashes when exiting emulation of Gecko OS) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for triggering the power event (in the STM), so that stopping emulation first triggers a shutdown event, which notably gives emulated software time to save game data (issue 8979) and clean up SYSCONF (to disconnect Wiimotes and update their state in the SYSCONF).
On the first press, the stop button/hotkey/whatever will trigger a STM power event, and we immediately show an OSD message, so it doesn't look like Dolphin is ignoring the stop command. On a second try, we will forcefully stop emulation, just like how it was working before.
Note: this still doesn't allow Wiimotes to trigger a poweroff when the last Wiimote is powered off. Not sure why; this will likely be something to look into in the future.
This change is