IPC_HLE: Remove unused _Unimplemented_Device_ device #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless I'm misreading the code, it doesn't look like this serves any purpose, and is only polluting the logs. _Unimplemented_Device_ looked like a device name that was picked to be used somewhere else in Dolphin, but this doesn't seem to be the case since 2012 (d95e31a removed the only other usage of this fake device).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm misreading the code, it doesn't look like this serves any purpose, and is only polluting the logs and creating a useless device.
_Unimplemented_Device_is apparently a device that was used for devices that don't exist, but this hasn't been the case since 2012 (d95e31a removed the only usage of this fake device).This change is