IPC_HLE: Move NWC24Config and WiiNetConfig to their own source files #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes for a cleaner separation of functionality, as well as removing multiple includes from the main header file. It also gets a bunch of structs and enums out of the global namespace. Coincidentally, this also gets rid of an indirect include cycle that could have broken compilation of Core.cpp in the future, since it was relying on IPC network includes to resolve functions in Common/NandPaths.h. This makes it easier to separate out the individual net classes in a follow-up. Separating these out would also make it less of a pain to figure out what's going on, since you wouldn't need to sift through 1000+ lines of code.i
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes for a cleaner separation of functionality, as well as removing multiple includes from the main header file. It also gets a bunch of structs and enums out of the global namespace.
Coincidentally, this also gets rid of an indirect include cycle that could have broken compilation of Core.cpp in the future, since it was relying on IPC network includes to resolve functions in Common/NandPaths.h.
This makes it easier to separate out the individual net classes in a follow-up. Separating these out would also make it less of a pain to figure out what's going on, since you wouldn't need to sift through 1000+ lines of code.
This change is