Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathConfigPane: Eliminate main frame global usage #4434

Merged
merged 2 commits into from Nov 10, 2016

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Nov 9, 2016

UI event systems are made specifically to avoid this sort of coupling between window types, so we may as well use it.


This change is Reviewable

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • aeon-charge-attack on ogl-lin-mesa: diff
  • cel-damage-lighting on ogl-lin-mesa: diff
  • ed-updated on ogl-lin-mesa: diff
  • fishing-resort-map on ogl-lin-mesa: diff
  • fsa-layers on ogl-lin-mesa: diff
  • hb-discgolf on ogl-lin-mesa: diff
  • jj-awae-mirrored on ogl-lin-mesa: diff
  • last-story-shadows on ogl-lin-mesa: diff
  • melee-lighting on ogl-lin-mesa: diff
  • mii-channel on ogl-lin-mesa: failed to render
  • mkwii-bluebox on ogl-lin-mesa: diff
  • nddemo-lighting on ogl-lin-mesa: diff
  • nes-vc on ogl-lin-mesa: diff
  • pw-black-bars on ogl-lin-mesa: diff
  • rs2-skybox on ogl-lin-mesa: diff
  • rs3-skybox2 on ogl-lin-mesa: diff
  • simpsons-game on ogl-lin-mesa: diff
  • smg-marioeyes on ogl-lin-mesa: diff
  • soa-black on ogl-lin-mesa: diff
  • soniccolors-mm on ogl-lin-mesa: diff
  • spyro-bloom on ogl-lin-mesa: diff
  • spyro-depth on ogl-lin-mesa: diff
  • ssbm-pointsize on ogl-lin-mesa: failed to render
  • super-sluggers-white-out on ogl-lin-mesa: diff
  • thps3-earlyz on ogl-lin-mesa: failed to render
  • xenoblade-menu on ogl-lin-mesa: failed to render
  • zelda1-vc on ogl-lin-mesa: diff

automated-fifoci-reporter

@BhaaLseN
Copy link
Member

BhaaLseN commented Nov 9, 2016

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@lioncash lioncash merged commit 0b9562b into dolphin-emu:master Nov 10, 2016
@lioncash lioncash deleted the path branch November 10, 2016 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants