Jit: Move most x86-64-specific code out of JitCommon #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
jit
branch
6 times, most recently
from
4b4175d
to
c786067
Compare
degasus
approved these changes
Dec 14, 2016
| @@ -18,25 +18,8 @@ | |||
| #include "Core/PowerPC/CPUCoreBase.h" | |||
| #include "Core/PowerPC/Jit64Common/Jit64AsmCommon.h" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| static const int FARCODE_SIZE = 1024 * 1024 * 8; | ||
| static const int FARCODE_SIZE_MMU = 1024 * 1024 * 48; | ||
| constexpr int FARCODE_SIZE = 1024 * 1024 * 8; | ||
| constexpr int FARCODE_SIZE_MMU = 1024 * 1024 * 48; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -21,7 +21,6 @@ | |||
| #include "Common/x64Emitter.h" | |||
| #include "Core/PowerPC/Gekko.h" | |||
| #include "Core/PowerPC/Jit64/JitAsm.h" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Mostly intended to clean up HandleFault than anything else.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves it over to Jit64Common, as well as very minor cleanup that follows the primary commit.