Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open less files when detecting/opening blobs #4537

Merged
merged 5 commits into from Jan 11, 2017
Merged

Open less files when detecting/opening blobs #4537

merged 5 commits into from Jan 11, 2017

Commits on Jan 11, 2017

  1. Only open file once when detecting blob type

    @JosJuice
    JosJuice committed Jan 11, 2017
    Copy the full SHA
    d1ea00e View commit details
    Browse the repository at this point in the history

  2. Don't create new IOFiles when creating a blob 

    ...except for WBFS, which is special because
it has the ability to open multiple files.
    @JosJuice
    JosJuice committed Jan 11, 2017
    Copy the full SHA
    8d54bbc View commit details
    Browse the repository at this point in the history

  3. WbfsBlob: Only open each file once 

    The first file used to be opened once by
CreateBlobReader and once inside WbfsFileReader.
    @JosJuice
    JosJuice committed Jan 11, 2017
    Copy the full SHA
    5c02795 View commit details
    Browse the repository at this point in the history

  4. WbfsBlob: Remove m_total_files 

    std::vector already keeps track of this for us.
    @JosJuice
    JosJuice committed Jan 11, 2017
    Copy the full SHA
    0363be4 View commit details
    Browse the repository at this point in the history

  5. WbfsBlob: Don't wrap file_entry in std::unique_ptr 

    There doesn't seem to be any reason for doing it.
    @JosJuice
    JosJuice committed Jan 11, 2017
    Copy the full SHA
    b187326 View commit details
    Browse the repository at this point in the history