Add the g_ prefix to the jit global #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
force-pushed
the
jit-warning-fixes
branch
from
662fe61
to
ad2737f
Compare
Jan 04 22:55:01 <leoetlino> fwiw, it looks like there are new warnings in the RegCache code Jan 04 22:55:04 <leoetlino> Source/Core/Core/PowerPC/Jit64/FPURegCache.cpp:13:33: warning: declaration shadows a variable in the global namespace [-Wshadow] Jan 04 22:56:19 <@lioncash> yeah, the jit global should have a g_ prefix. This fixes shadowing warnings and adds the g_ prefix to a global.
leoetlino
force-pushed
the
jit-warning-fixes
branch
from
ad2737f
to
8bef725
Compare
|
You missed ARM files? /var/lib/buildbot/slave/pr-android/build/Source/Core/Core/PowerPC/JitArm64/JitAsm.cpp |
|
Yes. This should be all fixed now though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the g_ prefix to a global, which fixes shadowing warnings.
This change is