Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sram: Make SRAM dumps const #4790

Merged
merged 1 commit into from Feb 1, 2017
Merged

Sram: Make SRAM dumps const #4790

merged 1 commit into from Feb 1, 2017

Conversation

lioncash
Copy link
Member

This is only used internally and isn't written to.

@lioncash
Sram: Make SRAM dumps const
093b611 
This is only used internally, and isn't written to.
@degasus
Copy link
Member

degasus commented Jan 31, 2017

And it is only used in this single file. Please mark it as static.

@lioncash
Copy link
Member Author

const internally links by default at file scope.

@degasus
Copy link
Member

degasus commented Feb 1, 2017

So a extern const SRAM sram_dump can't be used for linking? Doubt so.

@degasus degasus merged commit f558ae4 into dolphin-emu:master Feb 1, 2017
@lioncash lioncash deleted the sram branch February 1, 2017 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@lioncash @degasus