Move "Background Input" out of individual controller configurations #4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligfx
force-pushed
the
backgroundinput
branch
3 times, most recently
from
ec0fd25
to
44327bf
Compare
|
Oh, I wonder why this PR wasn't merged. It is a streight forward improvement. But with a few conflicts now... |
Somehow it acts as though it has wxEXPAND, but that stops working if the code is edited (as in the next commit).
|
@degasus Glad you like it! I've rebased on current master and fixed the conflicts. |
ligfx
force-pushed
the
backgroundinput
branch
2 times, most recently
from
7eb364b
to
1b0701e
Compare
|
Sounds fine to me. Sorry this fell through the cracks. @MayImilae Do you have any concerns with adding more options to the main input UI? I'm all for anything that simplifies the already dense controller config UI |
|
Bump |
ligfx
added a commit
to ligfx/dolphin
that referenced
this pull request
Mar 21, 2017
Fixes https://bugs.dolphin-emu.org/issues/10159 "Emulated Wii remote options not working correctly," which was introduced by PR dolphin-emu#4856: "Move 'Background Input' out of individual controller configurations."
ligfx
added a commit
to ligfx/dolphin
that referenced
this pull request
Mar 21, 2017
Fixes https://bugs.dolphin-emu.org/issues/10159 "Emulated Wii remote options not working correctly," which was introduced by PR dolphin-emu#4856: "Move 'Background Input' out of individual controller configurations."
mahdihijazi
pushed a commit
to mahdihijazi/dolphin
that referenced
this pull request
Apr 27, 2017
Fixes https://bugs.dolphin-emu.org/issues/10159 "Emulated Wii remote options not working correctly," which was introduced by PR dolphin-emu#4856: "Move 'Background Input' out of individual controller configurations."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's confusing that the setting is available on each individual configuration.
This patch moves it to the main Controller Config dialog to make it obvious that it's a global setting: