Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES: Replace useless asserts with proper checks #4956

Merged
merged 1 commit into from
Mar 1, 2017
Merged

ES: Replace useless asserts with proper checks #4956

merged 1 commit into from
Mar 1, 2017

Commits on Mar 1, 2017

  1. ES: Replace useless asserts with proper checks 

    It makes absolutely no sense to have asserts for what is obviously an
error condition. And they should definitely not cause Dolphin to crash
because it assumes that everything is valid, and Dolphin should not
report those to the user either, as it is very obviously a bug in the
emulated software and there is nothing the user (or we) can do.

This commit replaces all of the request asserts with proper checks
and adds missing checks for some ioctlvs. We still do not check sizes
yet; this will be done later.
    @leoetlino
    leoetlino committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    24e35f9 View commit details
    Browse the repository at this point in the history