IOS/ES: Check the content hash during imports #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Mar 8, 2017
Source/Core/Core/IOS/ES/ES.cpp
Outdated
| @@ -583,6 +584,13 @@ IPCCommandResult ES::AddContentData(const IOCtlVRequest& request) | |||
| return GetDefaultReply(IPC_SUCCESS); | |||
| } | |||
|
|
|||
| static bool CheckContentHash(const std::vector<u8>& content, const IOS::ES::Content& info) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This adds a hash check for imported contents. IOS does it for security; we do it for a somewhat different reason, to catch content decryption bugs before incorrectly decrypted contents get written to the NAND, which can cause titles to be corrupted. Either way, we should have been doing this check in all cases.
leoetlino
force-pushed
the
es-import-hash-check
branch
from
6029a50
to
daa5ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hash check for imported contents. IOS does it for security; we do it also for a somewhat different reason, to catch content decryption bugs before incorrectly decrypted contents get written to the NAND, which can cause titles to be corrupted.
Either way, we should have been doing this check in all cases.