Unify the way of setting game ID, title ID, revision

[JosJuice]

The existing code from ConfigManager, ES and MIOS is merged into a new set of functions called SetRunningGameMetadata.

[JosJuice]

There's an unfortunate thing with this: Some Wii disc games seem to have different revisions in the TMD than in the disc header. (Or am I just getting it the wrong way from the TMD?) I tried SSBB (RSBE01r1), and it had 1 in the disc header and 0 in the TMD.

When booting a Wii disc game, SetRunningGameMetadata ends up being called once with the TMD (which I assume is because of ES) after the boot process already has called it with the volume, so the disc header revision gets replaced. It doesn't really matter right now since we currently don't use the revision for anything after booting, but it will matter in the future if we get the ability to reload game INIs when changing game.

Just as a note: Before this PR, ES used to never update the revision. That doesn't seem like a good idea - we should either set it to a good value or to 0. (MIOS did the same with the title ID.)

[leoetlino]

There's an unfortunate thing with this: Some Wii disc games seem to have different revisions in the TMD than in the disc header.

Yes, the revision does not always match, sadly. I'm not sure how this can be solved -- maybe we should just always use the revision from the disc header for disc titles. But then we would have to go out of the way to get the revision from the disc, since ES only gets a TMD…

[JosJuice]

What do you think about calling SetRunningGameMetadata(DVDInterface::GetVolume()) from void SetRunningGameMetadata(const TMDReader& tmd) when IsDiscTitle(title_id)? (Maybe with an extra check to ensure that the volume's title ID is identical to tmd.GetTitleId(), in case someone has installed a channel with a weird ID that passes IsDiscTitle? And I suppose we'd need a VolumeIsValid() check too...)

[leoetlino]

Sounds good to me with that check. Actually -- if you have the tmd.GetTitleId() == volume.GetTitleId() check, it shouldn't be necessary to check IsDiscTitle.

[JosJuice]

Done.

[leoetlino]

LGTM