Move LoadPatches calls #5079
Move LoadPatches calls #5079
Conversation
LoadPatches was apparently never being called when booting Wii discs. Maybe this will fix the recent regression with cheat codes not getting loaded? I don't know how this managed to work to begin with, though... (The call was also moved for WADs, just for consistency.)
JosJuice
force-pushed
the
move-loadpatches
branch
from
3278d60
to
09682cf
Compare
|
(21:35:08) orbea: JosJuice: applied the PR to the master as a patch locally and it seems to have fixed it :) |
|
What about ELF + DOL? |
|
They don't have game IDs, so LoadPatches won't find any game INIs to load. Or, I guess they technically get a "00000000" ID because that's the default in Dolphin, so all ELFs/DOLs would share the file 00000000.ini... Do you want me to add LoadPatches calls to them? |
|
Now I understand how this worked before and why PR #5045 broke it. PR #4981 removed EmulatedBS2_Wii's call to LoadPatches (https://github.com/dolphin-emu/dolphin/pull/4981/files#diff-58b93180c3edb87056fe89eab1c69553L414), which was fine, because DIVerify calls LoadPatches anyway when it's updating the running game metadata. Then in PR #5045, I made it so that SetRunningGameMetadata won't do anything if the new game ID is identical to the previous one, so that we won't waste times re-loading things (especially custom textures can take some time). Because the game ID already has been set by AutoSetup before starting the boot process, the SetRunningGameMetadata call that we get in the boot process from calling DIVerify now does nothing. I was assuming that this simply would make the boot process act like it did before PR #4981, but I hadn't noticed that PR #4981 removed the LoadPatches call. So the result was basically that the boot process acted like before PR #4981 except LoadPatches never got called for Wii discs. |
LoadPatches was apparently never being called when booting Wii discs. Maybe this will fix the recent regression with cheat codes not getting loaded? I don't know how this managed to work to begin with, though...
(The call was also moved for WADs, just for consistency.)