VideoBackends: Fix crashes introduced by #4999 #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops the virtual method call from within the Renderer constructor. The initialization here for GL had to be moved to VideoBackend, as the Renderer constructor will not have been executed before the value is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash introduced by #4999, thanks to @sepalani for identifying it in #5050.
Other main issue was the crashing when higher internal resolutions were selected. This was a more complicated fix, due to the design of the base classes.
The most straightforward solution (and IMO the cleanest) was to move the max texture size to backend info. However, the initialization here for GL had to be moved to VideoBackend, as the Renderer constructor will not have been executed before the value is required.
IMO, we should move the remaining logic from the GL Renderer constructor here as well, especially the stuff that can cause startup to fail (which currently is not handled at all).